A federal judge has closed President Donald Trump’s lawsuit against the IRS and Treasury, but not without raising pointed questions about how the case ended and whether it ever presented a conventional adversarial dispute.